google / google/site-kit-wp

Consolidate `external` and `hideExternalIndicator` props into an `openInNewTab` prop or `target="_blank"`.

Open
#7,933 4 comments 0 reactions 1 assignee Assigned to @tofumatt View on GitHub
P2 Type: Infrastructure
Dominant language
JavaScript
Stars
1.4k
Forks
383
Avg merge
4d 14h
Merged PRs (30d)
77

Description

## Feature Description

See: https://github.com/google/site-kit-wp/pull/7847#discussion_r1402782242. More info to be filled out…

---------------

_Do not alter or remove anything below. The following sections will be managed by moderators only._

## Acceptance criteria

* Base `Link` component:
* Accepts new prop `openInNewTab` prop to indicates that link should be opened in a new tab
* Accepts new prop `hasExternalIcon` to indicate that external icon should be included
* Existing `external ` and `hideExternalIndicator` props are removed
* Components using `Link` should be updated to use new props correctly

## Implementation Brief

*

### Test Coverage

*

## QA Brief

*

## Changelog entry

*

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.