google / google/site-kit-wp

Relocate fallback mechanism for RRM identifiers to the datastore from PHP datapoints

Open
#13,429 0 comments 0 reactions 1 assignee Claimed by @nfmohit View on GitHub
Module: RRM P2 Team M Type: Enhancement
Dominant language
JavaScript
Stars
1.4k
Forks
384
Avg merge
4d 14h
Merged PRs (30d)
77

Description

## Feature Description

RRM publication and CTA requests currently resolve `organizationID` / `publicationID` in two places: the JS datastore falls back to module settings when the IDs are omitted, and the PHP datapoints do the same.

That duplication is leftover from layering CTA infrastructure on top of the existing publication endpoints. It forces the PHP classes to depend on settings only to fill in missing IDs, and it keeps two fallback implementations in sync.

This refactor should resolve both IDs in the datastore and always send them to the REST layer. PHP then only validates that they are present. Datastore callers can still omit the IDs; the REST endpoints become strict. Behavior should stay the same.

Relevant conversation: https://github.com/google/site-kit-wp/pull/13208#discussion_r3836922036
PoC: https://github.com/google/site-kit-wp/pull/13430

---------------

_Do not alter or remove anything below. The following sections will be managed by moderators only._

## Acceptance criteria

*

## Implementation Brief

* [ ]

### Test Coverage

*

## QA Brief

*

## Changelog entry

*

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.