google / google/site-kit-wp

Odd UX/UI experience when declining the TOS when setting up Analytics

Open
#13,258 0 comments 0 reactions 0 assignees View on GitHub
Module: Analytics Type: Bug
Dominant language
JavaScript
Stars
1.4k
Forks
383
Avg merge
4d 14h
Merged PRs (30d)
77

Description

## Bug Description

The user sets up Analytics via settings, and they decline the TOS. The user is redirected back to the settings in create an account view, all good. The issue is if I navigate away from the Analytics settings in error, and then go back in and click on Edit, the error message still appears which is expected, but when I click on the Go to Analytics CTA button, it just closes down the settings, and doesn't redirect me to the TOS screen. This only occurs if I navigate away from settings after the error notification appears.

I discussed this on [12876](https://github.com/google/site-kit-wp/issues/12876#issuecomment-4879748113) with Nahid, and we agreed to create a ticket.

https://github.com/user-attachments/assets/d2bed7bd-0268-4962-be08-ab6312d0dee2

## Steps to reproduce

1. Set up Analytics via the Site Kit settings
2. Go through creating a new account and when you get to the TOS screen, decline
3. You will be redirected back to the settings screen.
4. Navigate away from the settings, and then go back in and you are unable to retry setting up Analytics.

---------------

_Do not alter or remove anything below. The following sections will be managed by moderators only._

## Acceptance criteria

*

## Implementation Brief

* [ ]

### Test Coverage

*

## QA Brief

*

## Changelog entry

*

Contributor guide

Open the contributing guide

Research direction

Start by reproducing the declined-TOS flow in the Analytics settings and then navigating away before selecting Edit again. Trace the Go to Analytics CTA from the returned settings state; done means it opens the TOS screen instead of only closing the settings.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.