Get help with AdSense help menu item appearing on view-only dashboard
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 1.4k
- Forks
- 384
- Avg merge
- 4d 14h
- Merged PRs (30d)
- 77
Description
Bug Description
On the view only dashboard, if the user (e.g an Editor) does not have access to AdSense, the menu option Get help with AdSense appears in the help menu. We shouldn't show the menu option when the user does not have access.
Screenshots
Steps to reproduce
- Set up Site Kit with AdSense as an admin user.
- Set up desktop sharing but do not give access to AdSense for a view-only user.
- Login to the dashboard as the view-only user (Editor)
- Observe the
Get help with Adsensemenu option in the help menu.
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
Implementation Brief
Test Coverage
QA Brief
Changelog entry
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the issue by following the four steps in the report, then trace the view-only dashboard's help menu and the access check for AdSense. Confirm the menu item is hidden for an Editor without AdSense access while remaining available to users who have access, and add or update regression coverage if the relevant test entry point is found.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 55/100