google / google/site-kit-wp

Investigate `assets/js/components/FeatureTours.js` to potentially refactor/move `useEffect` code

Open
#11,352 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
1.4k
Forks
383
Avg merge
4d 14h
Merged PRs (30d)
77

Description

## Feature Description

Raised [here](https://github.com/google/site-kit-wp/pull/11271#discussion_r2289035453), we should investigate logic within `useEffect` hook

> why not just add this as an effect into the main dashboard? Why do we have a ResizeObserver which simply emits resize events? Is this even still needed? (Maybe newer versions of Joyride have addressed this?) Why is this only concerned with the main dashboard when this component is rendered as part of Root?

---------------

_Do not alter or remove anything below. The following sections will be managed by moderators only._

## Acceptance criteria

*

## Implementation Brief

* [ ]

### Test Coverage

*

## QA Brief

*

## Changelog entry

*

Contributor guide

Open the contributing guide

Research direction

Start by reading assets/js/components/FeatureTours.js and the discussion in pull request #11271. Trace the useEffect, ResizeObserver, and Joyride-related behavior when FeatureTours is rendered from Root and on the main dashboard. Done means deciding whether the logic is still needed and documenting or implementing its appropriate location, with relevant tests updated if identified.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.