google / google/site-kit-wp

Audit VRT scenarios and prune low value cases

Open
#10,798 2 comments 2 reactions 1 assignee Claimed by @tofumatt View on GitHub
P1 Type: Infrastructure
Dominant language
JavaScript
Stars
1.4k
Forks
384
Avg merge
4d 14h
Merged PRs (30d)
77

Description

## Feature Description

When we originally migrated to Storybook v6 and Component Story Format stories, one of the goals was to make it easier to co-locate VRT scenario definitions with their respective stories. However, since then, one side-effect has been our set of VRT scenarios growing substantially. Today, the VRT step alone takes over 20 minutes to complete in GitHub actions which is our longest-running job.

Part of the issue is that Backstop did not previously support scenario-level viewport configuration, so all scenarios ended up 3 images (one for each defined viewport).

This issue is to review the scenarios we currently have defined and identify any which aren't adding much value and can be removed.

---------------

_Do not alter or remove anything below. The following sections will be managed by moderators only._

## Acceptance criteria

*

## Implementation Brief

* [ ]

### Test Coverage

*

## QA Brief

*

## Changelog entry

*

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.