google / google/site-kit-wp

`WebDataStreamNotAvailableNotification` triggers GA4 settings fetch on dashboard when module not connected

Open
#10,259 1 comment 1 reaction 1 assignee Claimed by @jimmymadon View on GitHub
Module: Analytics Next Up P1 Type: Bug
Dominant language
JavaScript
Stars
1.4k
Forks
384
Avg merge
4d 14h
Merged PRs (30d)
77

Description

## Bug Description

In #9291 we updated this notification to use the new Notifications API. In doing so, a small regression was introduced which causes GA4 settings to be fetched when the module isn't connected.

## Steps to reproduce

1. Connect Site Kit from a clean state with minimal setup only
2. Observe `analytics-4` settings fetch on dashboard

---------------

_Do not alter or remove anything below. The following sections will be managed by moderators only._

## Acceptance criteria

* No requests to Analytics endpoints should be invoked on the SK dashboard when the module is not connected

## Implementation Brief

* [ ]

### Test Coverage

*

## QA Brief

*

## Changelog entry

*

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.