google / google/shaderc

Shaderc build breaks due to mismatch SPIRV-Tools w.r.t. Glslang

Open
#417 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
2.2k
Forks
445
Avg merge
11h 6m
Merged PRs (30d)
6

Description

Shaderc bots are broken because:
- Shaderc builds are configured to use latest SPIRV-Tools
- Glslang (and its tests) assume a specific version of SPIRV-Tools
- Glslang golden test results are sensitive to SPIRV-Tools transforms
- SPIRV-Tools transforms evolve.
- So there can be a mismatch on Glslang test results in Shaderc's build bots.

The latest example is a recent improvement to block merging in SPIRV-Tools.

It's unclear how often this will occur. I'm keeping this open to document the issue, and to avoid a general panic. :-)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.