google / google/shaderc

re2 dropped support for VS 2017. Need to keep re2 dependency pinned

Open
#1,338 0 comments 0 reactions 1 assignee Claimed by @dneto0 View on GitHub
version/release
Dominant language
C++
Stars
2.2k
Forks
445
Avg merge
11h 6m
Merged PRs (30d)
6

Description

RE2 will not compile with a compiler older than VS2019.
See https://github.com/google/re2/blob/7c5e396af825562ec8321fdbf2f1cf276b26e3ae/CMakeLists.txt#L39

So the DEPS needs to pin the re2 dependency to a commit before May 2023. At least until we can increase the minimum compiler to VS2019.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.