google / google/shaderc

Support for combinedImageSamplers?

Open
#1,310 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
2.2k
Forks
445
Avg merge
11h 6m
Merged PRs (30d)
6

Description

The microsoft compiler supports a special atribute for compatibility with glsl:
https://github.com/microsoft/DirectXShaderCompiler/wiki/Vulkan-combined-image-sampler-type

However declaring this in an hlsl shader:
```
[[vk::combinedImageSampler]]
Texture2D textures[3] : register(t1);
```

And compiling with shaderc results in the error:
`examples/02_skinned_mesh/test.frag.hlsl:1: warning: 'combinedImageSampler' : unrecognized attribute`

It would be a nice addition to shaderc I think. I would certainly find it very useful.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.