google / google/shaderc

Build should not rely on SPIRV-Tools CHANGES, but the generated file.

Open
#1,296 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
2.2k
Forks
445
Avg merge
11h 6m
Merged PRs (30d)
6

Description

Shaderc build is relying on the format of the SPIRV-Tools `CHANGES` file, which is hand-made. Shaderc should rely on the generated file instead, `build-version.inc`, which has a format which is supposed to be parsed, hence stable.

Because of a change of release process, the `CHANGES` file won't reflect the exact version number for SPIRV-Tools anymore, so this might break shaderc.

(See https://github.com/KhronosGroup/SPIRV-Tools/pull/5067)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.