google / google/security-research

Formatting of reward amounts is weird

Open
#92 0 comments 1 reaction 1 assignee Claimed by @koczkatamas View on GitHub
Dominant language
C
Stars
4.6k
Forks
582
Avg merge
1d 5h
Merged PRs (30d)
3

Description

on https://github.com/google/security-research/blob/master/kernelctf/rules.md, formatting the rewards amounts to 3 decimal places is just awkward. On that page, I see the following reward amounts:

* $21.337
* $10.000
* $20.000
* $21.000
* $10.500
* $0 to $20.000

This is really confusing, as the separator for whole vs fractional numbers differs by region: https://en.wikipedia.org/wiki/Decimal_separator

For those that are used to using a period "." as a group separator for large numbers, someone could read "$21.337" to mean "twenty-one thousand... dollars". If that is the intent here, I would maybe not use the USD symbol, as most people assume a period "." is used as a decimal separator.

Most people use the hint of only having 2 decimal to know which format you are talking about. If this page is indeed treating "21.337" to mean "21 dollars and 337 cents), I would explicitly state that or change the formatting of these numbers.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.