google / google/secrets-gradle-plugin

Merged Manifest error

Open
#41 18 comments 1 reaction 1 assignee Claimed by @arriolac View on GitHub
type: bug
Dominant language
Kotlin
Stars
1.3k
Forks
122
PR merge metrics
No merged PRs in 30d

Description

So I followed [this](https://developers.google.com/maps/documentation/android-sdk/start#add-key) guide from the Maps SDK to add the API key to the app.
Now in Android Studio the Merged Manifest view no longer works which in turn also breaks the `MissingPermission` lint.

Android Studio shows this error when viewing the Merged Manifest:
> Merging Errors: Error: Attribute meta-data#com.google.android.geo.API_KEY@value at AndroidManifest.xml:57:13-44 requires a placeholder substitution but no value for is provided. redacted.app main manifest (this file), line 56 Error: Validation failed, exiting redacted.app main manifest (this file)

`MissingPermission` lint warning, despite the permissions being in `AndroidManifest.xml`:
> Missing permissions required by FusedLocationProviderClient.requestLocationUpdates: android.permission.ACCESS_COARSE_LOCATION or android.permission.ACCESS_FINE_LOCATION

A workaround would be to manually add `manifestPlaceholders = [MAPS_API_KEY: ""]` to the app build.gradle, but this feels wrong.
Is there a better way to avoid this, or is this more an error by Android Studio or the Android Gradle plugin?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.