google / google/secops-wrapper

breaking change of list_parsers and others by introducing as_list option

Open
#223 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
92
Forks
48
PR merge metrics
No merged PRs in 30d

Description

introducing default "as_list: bool = True," for below methods introduces a breaking and inconsistent change, as others default to False.

[https://github.com/search?q=repo%3Agoogle%2Fsecops-wrapper+%22as_list%3A+bool+%3D+True%22&type=code](https://github.com/search?q=repo%3Agoogle%2Fsecops-wrapper+%22as_list%3A+bool+%3D+True%22&type=code)

pls change default to old way of returning "raw api response with pageination info", or default to True everywhere.

Contributor guide

Open the contributing guide

Research direction

Search the repository for methods declaring "as_list: bool = True" using the linked code-search query, then compare their defaults and return behavior with the other parser methods. Decide whether the defaults should preserve the raw API response with pagination information or be consistent across methods, and verify all affected methods follow the chosen behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
api, backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
62/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.