Boiler Fails with High Outside Air Temp
Open
bug
question
- Dominant language
- Python
- Stars
- 123
- Forks
- 56
- Avg merge
- 17d 18h
- Merged PRs (30d)
- 3
Description
This assertion in the boiler causes simulations to fail on hot days (like Oct 6 2024) where the outdoor air temp exceeds the hot water temp.
https://github.com/google/sbsim/blob/c23069131e841a08d41102330eecde452861bcc6/smart_control/simulator/boiler.py#L296
Besides changing this non-test assertion into a value error (which we already have an issue about #28 ), it would be very helpful to learn more about why this assertion is in place, and if it is necessary. Ideally we would like to implement a fix that allows the simulation to work on hot days.
@Jgoldfeder do you have any context to share about this logic?
Contributor guide
Assessment
This issue has not been assessed yet.