google / google/sbsim

Rename Setpoint Schedule

Open
#129 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
123
Forks
56
Avg merge
17d 18h
Merged PRs (30d)
3

Description

The `SetpointSchedule` class ("smart_control/simulator/setpoint_schedule.py") isn't really about device setpoint ranges, but really represents the building's comfortable air temperature ranges.

We should consider renaming the class to more accurately reflect its purpose, perhaps `BuildingComfortSchedule` or `BuildingOperationalSchedule`.

This would allow us to add a new `SetpointSchedule` or `DeviceSetpointSchedule` class to handle the schedule of desired device setpoint values (air temperature, hot water heating temp, etc) in eco vs comfort mode.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.