google / google/sandboxed-api

Throw an error when function doesn't exist

Open
#94 1 comment 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
C++
Stars
1.8k
Forks
200
Avg merge
12d 2h
Merged PRs (30d)
1

Description

In the sapi_library, one of the parameters is a list of sandboxed functions.
Currently, when a symbol doesn't exist in the library, it's silently ignored.

I think this behavior is misleading.
If the API of the library is changed, there won't be any indication while building the SAPI library.
In some cases, this also may lead to extensive debugging from users why such function is not exposed in API class.

We should throw an error when a function can't be found in the library.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.