google / google/sagetv

Favorite Padding Not Honored

Open
#363 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
287
Forks
172
PR merge metrics
No merged PRs in 30d

Description

I don't know how long this has been the case but tonight I noticed that favorite padding is not honored when two of the same favorite airs back to back _even though it is only recording one of the two shows._

Example 1: Our local PBS station is showing Ken Burns' "The Vietnam War", for which I created a favorite. I specified in the favorite padding of 1 minute on each side of the show. The first episode is Sunday at 7pm, which the scheduler has chosen to record. A repeat of the same show starts immediately afterword starting at 8:30pm. This episode, being a repeat, is not scheduled to record. With the +/- 1 minute of padding, I would expect the 7pm recording to run from 6:59 to 8:31pm. What I actually see is the recording starts at 6:59pm, but ends at 8:30 (post padding is lost). This occurs throughout the week as our local PBS is airing each episode twice, back to back. When looking at the parallel recording schedule, there is no other recording scheduled for that tuner that explains the loss of padding.

Example 2: I have a favorite for "Mystery Science Theater 3000" which airs on our local Comet affiliate. Typically, two episodes are broadcast in succession. Like Example 1, this favorite has 1 minute of padding on each side of the show. This weekend the first episode airs from 7:00pm to 9:15pm. It is not recording because ~~it has already been watched~~ it was previously recorded (but not yet watched). The second episode begins at 9:15pm and ends at 11:30pm and is scheduled to record. With +/- 1 minute of padding, it should record from 9:14 - 11:31. What I actually see is the recording is scheduled from 9:15 through 11:31 (pre padding is lost). As before, parallel view shows this tuner has no recordings scheduled that would interfere with the padding.

Based on this, it appears that back to back favorites confuse the scheduler and the padding is lost where they meet, as if both episodes were recorded, even though only one of them is to be record.

Software is the Docker verison of SageTV server 9.1.6.372, Windows 7 client 9.1.6.372. The tuner involved in both examples is a HD Homerun "classic".

Contributor guide

Open the contributing guide

Research direction

No files, tests, or entry points are named. Start by reproducing the two back-to-back favorite scenarios with one episode scheduled and padding enabled, then trace the scheduler behavior at the adjacent episode boundary. Done means the scheduled recording retains the configured pre-padding and post-padding when the neighboring repeat is not recorded.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
backend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.