google / google/sagetv

SageConstants -- more cleanup

Open
#328 15 comments 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
287
Forks
172
PR merge metrics
No merged PRs in 30d

Description

public static final boolean LITE = false;
public static final boolean ENFORCE_EMBEDDED_RESTRICTIONS = false;
public static final boolean PVR = true;
public static final boolean SERVER_FUNCTION = true;
public static final boolean LIBRARY_FUNCTION = true;

ENFORCE_EMBEDDED_RESTRICTIONS is never read, so it can be removed.

All other constants here are read in MANY places but the contant is never updated (and it's final, so, it can't be changed), so it begs the question... Should we remove these?

This is again, in the spirit of clean up. There is lots of if/else blocks using these constants. But if they never change, can/should they be removed? It may help to understand what the function of each of these was supposed to be.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.