google / google/sagetv

Expression is always false

Open
#305 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
287
Forks
172
PR merge metrics
No merged PRs in 30d

Description

Hi!

This [expression](https://github.com/google/sagetv/blob/f1f12ee3f4fcaf3f3b534f028f054b38ba00f8ee/java/sage/FastMpeg2Reader.java#L2123)
`((b & 0xE0) == 0x30)`
is always false.

0xE0 = 0000 0000 1110 0000b
------------------------^
0x30 = 0000 0000 0011 0000b
------------------------^
The fifth bit of expression (b & 0xE0) is 0 anyway.

This possible defect found by [AppChecker](https://npo-echelon.ru/en/solutions/appchecker.php).

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.