google / google/sagetv

Installer not setting registry permissions

Open
#261 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
287
Forks
172
PR merge metrics
No merged PRs in 30d

Description

From multiple reports in the forum, many people are unable to get sage to acknowledge their java heap changes. At least one has found that the permissions on the key were not set to Everyone. It looks like the installer IS setting it to 'Everyone' on the SOFTWARE\Frey Technologies key, but doesn't set any others. This would be fine when starting from scratch, because all the keys below this root would inherit their parents permissions when created, but if upgrading from a system that doesn't have permissions set this way, it will change it on the root, but since the others (Common, for instance) are not being changed, I don't think they get fixed. I don't know if adding the permission tag to all the entries in the sagetvregistry.wxs file would work, or not. The concern is the JVM Heap entry, which is not created nor edited by the installer, so I don't know how best to deal with that.

Of course, my other solution is to simply set the default heap size to 1024MB anyway, so it doesn't matter for most users going forward on windows...

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.