google / google/sagetv

PMT presence is causing raw stream detection to fail.

Open
#197 8 comments 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
287
Forks
172
PR merge metrics
No merged PRs in 30d

Description

A valid PAT and all of the PMT's are present, but none of the PMT's reference the actual streams available in the transport stream. Admittedly, this makes the file not work with a lot more players than just SageTV and once again, the provider doing things badly is Comcast. This happens for at least one user on two different channels consistently. Below is a video clip with the issue.

https://drive.google.com/open?id=0B4AD2tiek6XiUjhlaUw0dExNNlE

I propose we could address this situation by removing the presence of the PMT packet as a reason we will not eventually just use all of the streams we have found after a specific amount of data has been processed. As a fail-safe, I would make the presence of valid PMT packets raise the threshold for a naked stream significantly so it's less likely that we accidentally end up with a naked stream when it just happens to be a really high bit-rate transport stream.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.