google / google/s2geometry

min_site_separation_ is unused outside of ChooseInitialSites

Open
#613 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
2.7k
Forks
357
Avg merge
11h 4m
Merged PRs (30d)
1

Description

I noticed that since c84fc2a0cea28d98fc005057754f58bb439506f3 `s2builder.cc` stopped using `min_site_separation_` outside `ChooseInitialSites`.
If that's on purpose then `min_site_separation_` could be a local variable inside inside `ChooseInitialSites` instead of class scoped.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.