google / google/s2geometry

swig->pybind11 compat wrapper

Open
#583 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
2.7k
Forks
357
Avg merge
11h 4m
Merged PRs (30d)
1

Description

There should be a wrapper so people can continue using the swig interface with the implementation switched over to pybind11.

The tests in https://github.com/google/s2geometry/blob/master/src/python/s2geometry_test.py should pass.

This means the `%unignore`d functions in https://github.com/google/s2geometry/blob/master/src/python/s2_common.i need to be in the pybind11 bindings.

@deustis

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.