google / google/s2geometry

S1Angle::SinCos broken on ubuntu 22

Open
#413 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
2.7k
Forks
357
Avg merge
11h 4m
Merged PRs (30d)
1

Description

I tried to enable the test workflow for ubuntu 22 and get a failure due to `sincos`.

```
/home/runner/work/s2geometry/s2geometry/src/s2/s1angle_test.cc:139: Failure
Expected equality of these values:
sin_cos.cos
Which is: -0.2[58](https://github.com/google/s2geometry/actions/runs/13603572823/job/38032416706?pr=412#step:8:59)81904510251996
cos(angle)
Which is: -0.25881904510251991

[ FAILED ] S1Angle.Trigonometry (0 ms)
```

https://github.com/google/s2geometry/actions/runs/13603572823/job/38032416706?pr=412#step:8:58

I will disable `sincos` for glibc until we can narrow this down further.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.