google / google/s2geometry

Better to use enum class instead of enum

Open
#205 4 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
2.7k
Forks
357
Avg merge
11h 4m
Merged PRs (30d)
1

Description

eg. In s2shape_index.h:
```
enum InitialPosition { BEGIN, END, UNPOSITIONED };
```
Such an enum name like `BEGIN` is very common, so it is easy to have the same name with a macro or other enum, which will cause conflict.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.