google / google/s2-geometry-library-java
Possible bug in compareEdges
Open
- Dominant language
- Java
- Stars
- 587
- Forks
- 231
- PR merge metrics
- No merged PRs in 30d
Description
The C++ and Java versions of `compareEdges` don't match as the C++ compare `a1` and `b1`, while the Java compare `b0` and `b1`.
I guess the C++ version is the correct one?
https://github.com/google/s2geometry/blob/fde443b85c018d2991b7459630932add72ef6f76/src/s2/s2edge_crossings.h#L63
https://github.com/google/s2-geometry-library-java/blob/57151fc0f7fe543b75e9f743bf897e81928d5c3f/library/src/com/google/common/geometry/S2EdgeUtil.java#L3101
Contributor guide
Assessment
This issue has not been assessed yet.