google / google/s2-geometry-library-java

S2CellUnionTests Line 258-260 should be removed.

Open
#1 0 comments 0 reactions 0 assignees View on GitHub
auto-migrated Priority-Medium Type-Defect
Dominant language
Java
Stars
587
Forks
231
PR merge metrics
No merged PRs in 30d

Description

```
Line 258-260 as below should be removed:

if (!u.contains(xId)) {
u.getIntersection(xCells, yId);
}

It is extraneous and guarantees the subsequent assertTrue(u.contains(xId)); on
line 261 will always work even though this is the line that is being ultimately
tested.
```

Original issue reported on code.google.com by `uvico...@gmail.com` on 9 Jul 2013 at 1:39

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.