google / google/react-schemaorg

Make TypeScript peer dependency optional

Open
#59 0 comments 1 reaction 0 assignees View on GitHub
Dominant language
TypeScript
Stars
521
Forks
20
PR merge metrics
No merged PRs in 30d

Description

Thanks for this library!

I'm noticing that because TypeScript is a [peer dependency](https://github.com/google/react-schemaorg/blob/dac2d83725b210c13a0dff54e9b2271765141837/package.json#L31) that when this library is used as dependency in a package that bundles to JavaScript, when that package is installed, TypeScript is also installed, even when the project does not use TypeScript.

I'm guessing the idea is to try to ensure compatibility with the types, but it's ~40MB to install TypeScript that might be avoided by making this peer dependency optional.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.