google / google/quiche

OnCanCreateNewOutgoingStream in SpdySession

Open
#63 7 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
897
Forks
177
PR merge metrics
No merged PRs in 30d

Description

Hi,
I am trying to make unit test for the MAX_STREAM property in my WebTransport lib.
I ran into an issue, if the number of bidirectional streams is increased the visitor was not informed.
I tracked it down to
https://github.com/google/quiche/blob/87cb8c8ba9c05dbeb623177d5bba0ce43d38112d/quiche/quic/core/http/quic_spdy_session.cc#L1619
which does not inform in case of bidrectional streams.
The new generic session does it:
https://github.com/google/quiche/blob/87cb8c8ba9c05dbeb623177d5bba0ce43d38112d/quiche/quic/core/quic_generic_session.cc#L170
It is not a big deal, since I can overload the method, but I am wondering, if it is intentional and if I am missing something.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.