google / google/qkeras

`pyparser` vs `pyparsing`

Open
#109 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
584
Forks
108
PR merge metrics
No merged PRs in 30d

Description

I see you have both `pyparser` and `pyparsing` in your `requirements.txt`. However, only `pyparser` is in the `setup.py` as a dependency. Moreover, I only see a use of the `pyparsing` library in the code.

It seems to me that *only* `pyparsing` should be in the `requirements.txt` *and* in `setup.py` as a dependency. What do you all think?

For reference:
- `pyparser`: Code: https://keep.imfreedom.org/grim/pyparser, PyPI: https://pypi.org/project/pyparser/
- `pyparsing`: Code: https://github.com/pyparsing/pyparsing, PyPI: https://pypi.org/project/pyparsing/

Contributor guide

Open the contributing guide

Research direction

Start by comparing requirements.txt and setup.py, then inspect the code references to pyparsing. Confirm which package is actually required, update both dependency declarations consistently, and verify that installation and the existing test suite still work.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
build-system
Issue type
Bug
Difficulty
1/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.