google / google/python-fire

Use another augmented assignment statement

Open
#359 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
28.2k
Forks
1.5k
PR merge metrics
No merged PRs in 30d

Description

:eyes: Some source code analysis tools can help to find opportunities for improving software components.
:thought_balloon: I propose to [increase the usage of augmented assignment statements](https://docs.python.org/3/reference/simple_stmts.html#augmented-assignment-statements "Augmented assignment statements") accordingly.

```diff
diff --git a/fire/core.py b/fire/core.py
index 8ca142c..67b1c72 100644
--- a/fire/core.py
+++ b/fire/core.py
@@ -570,7 +570,7 @@ def _Fire(component, args, parsed_flag_args, context, name=None):
if used_separator:
# Add back in the arguments from after the separator.
if remaining_args:
- remaining_args = remaining_args + [separator] + saved_args
+ remaining_args += [separator] + saved_args
elif (inspect.isclass(last_component)
or inspect.isroutine(last_component)):
remaining_args = saved_args
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.