google / google/protobuf-gradle-plugin
Gradle protobuf plugin still uses Configuration.setVisible()
- Dominant language
- Groovy
- Stars
- 1.8k
- Forks
- 288
- PR merge metrics
- No merged PRs in 30d
Description
Since Gradle 9.0.0, the `Configuration.setVisible()` no longer has a meaningful effect. We will be deprecating this method in Gradle 9.8.0 with eventual removal in Gradle 11.0.0.
The protobuf plugin calls this method [here](https://github.com/google/protobuf-gradle-plugin/blob/master/src/main/groovy/com/google/protobuf/gradle/ProtobufPlugin.groovy#L166) and [here](https://github.com/google/protobuf-gradle-plugin/blob/master/src/main/groovy/com/google/protobuf/gradle/ProtobufPlugin.groovy#L187).
Since this method has no effect any more, the correct resolution here would be to simply remove the method call.
Contributor guide
Research direction
Open src/main/groovy/com/google/protobuf/gradle/ProtobufPlugin.groovy and inspect the calls at lines 166 and 187. Remove both Configuration.setVisible() calls; the work is done when the plugin no longer invokes this deprecated, ineffective method.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- groovy
- Domain
- build-system
- Issue type
- Refactor
- Difficulty
- 1/5
- Estimated time
- 1-3 hours
- Activity status
- Quiet
- Clarity
- Clearly specified
- Newbie friendliness
- 88/100