google / google/protobuf-gradle-plugin

Locator dependency being created with invalid version value if it is not specified

Open
#798 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Groovy
Stars
1.8k
Forks
288
PR merge metrics
No merged PRs in 30d

Description

Given the following configuration the plugin adds a dependency which `dep.getVersion()` returns `"null"` (a string with `null` value in it):

```groovy
protobuf {
protoc {
artifact = 'com.google.protobuf:protoc'
}
}
```

Before `0.9.6` it was correctly set to `null`. The issue introduced in https://github.com/google/protobuf-gradle-plugin/pull/786.

Whilst everything it seems working fine, it doesn't feel like the correct behaviour and some plugins that operate with dependencies might break/behave incorrectly because of that.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.