google / google/protobuf-gradle-plugin

Protobuf plugin doesn't work with "com.android.dynamic-feature" plugin

Open
#554 1 comment 4 reactions 0 assignees View on GitHub
android compatibility
Dominant language
Groovy
Stars
1.8k
Forks
288
PR merge metrics
No merged PRs in 30d

Description

The Android gradle plugin added ["com.android.dynamic-feature"](https://developer.android.com/guide/playcore/feature-delivery). This plugin intends to replace the "com.android.feature" plugin.

Currently the Protobuf plugin doesn't work with "com.android.dynamic-feature" as it is not in [PREREQ_PLUGIN_OPTIONS](https://github.com/google/protobuf-gradle-plugin/blob/5eade538f61de06445273ea4d4346bb4f977a82b/src/main/groovy/com/google/protobuf/gradle/ProtobufPlugin.groovy#L58). It should be enough to add it in the list, but I haven't tested this so more may be required.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.