google / google/protobuf-gradle-plugin

ProtobufExtract filteredProtos and normalization

Open
#479 3 comments 1 reaction 0 assignees View on GitHub
enhancement performance enhancement
Dominant language
Groovy
Stars
1.8k
Forks
288
PR merge metrics
No merged PRs in 30d

Description

In our project we have metadata in `META-INF/MANIFEST.MF` which we're currently ignoring [ignoring](https://docs.gradle.org/current/javadoc/org/gradle/normalization/MetaInfNormalization.html#ignoreCompletely--)

But when comparing builds we see `extractIncludeProtos` keep appearing on account of `filteredProtos` having jar-files with different content.

And this makes me wonder, shouldn't `extractIncludeProtos` be annotated with [@Classpath](https://docs.gradle.org/current/javadoc/org/gradle/api/tasks/Classpath.html) rather than `@InputFiles`?

Going by `The content of the jar file is normalized so that time stamps and order of the zip entries in the jar file do not matter.` this sounds like it'd be a perfect fit

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.