google / google/pprof

Add tests for javascript code

Open
#791 3 comments 0 reactions 1 assignee Claimed by @ghemawat View on GitHub
Priority: p2 type: feat
Dominant language
Go
Stars
9.3k
Forks
671
Avg merge
1d 11h
Merged PRs (30d)
10

Description

Per @ghemawat from https://github.com/google/pprof/pull/790:

None of the javascript in pprof is tested.

One alternative is that we might need to install node in some github action and use that (maybe something like https://github.com/browser-actions/examples).

Another alternative would be to do manually triggered tests: if pprof is invoked with a special flag, it passes that to the javascript, and the javascript code when it sees that flag runs self tests. But it would be better to figure out how to have real tests.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.