google / google/pprof

web: flamegraph: show filename in tooltip

Open
#655 11 comments 0 reactions 0 assignees View on GitHub
Priority: p3 type: feat
Dominant language
Go
Stars
9.3k
Forks
671
Avg merge
1d 11h
Merged PRs (30d)
10

Description

Forked off from https://github.com/google/pprof/pull/649#issuecomment-930796262

### What version of pprof are you using?

7fe48b4c820be13151ae35ce5a5e3f54f1b53eef

### What did you do?

Open the flamegraph view in the web browser:

![image](https://user-images.githubusercontent.com/105529/135585350-a5d7ce57-6b37-441e-bba9-26ae8bb582df.png)

### What did you expect to see?
Filename in the tooltip -- in this case I used `-roottag thread` to add synthetic stack frames to the root of the trace, with the Filename = "thread", so help label the node.

### What did you see instead?
No filename.

Fixing this might require moving to a DOM-element for the tooltip, I'm not sure if browsers natively support multiline tooltips?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.