google / google/pprof

"(inline)" marker may be incorrect when -show or -hide filter is used

Open
#511 0 comments 0 reactions 0 assignees View on GitHub
Priority: p2 type: bug
Dominant language
Go
Stars
9.3k
Forks
671
Avg merge
1d 11h
Merged PRs (30d)
10

Description

The inline flag may be inaccurate if 'show' or 'hide' filter is used. Those filters may filter out some of entries in the line array causing a remaining entry (which is physically inlined) to be the rightmost entry in the filtered array, and this heuristic will erroneously consider that line entry as not inlined.

Example:

```
$ go run pprof.go -top -symbolize=none -show=math.Abs internal/report/testdata/sample.cpu | grep math.Abs
show=math.Abs
110ms 6.25% 6.25% 110ms 6.25% math.Abs
$ go run pprof.go -top -symbolize=none internal/report/testdata/sample.cpu | grep math.Abs
0.11s 6.25% 87.50% 0.11s 6.25% math.Abs (inline)
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.