google / google/pprof

Label with zero int64 value and no unit get dropped during decoding

Open
#1,002 6 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
9.3k
Forks
671
Avg merge
1d 11h
Merged PRs (30d)
10

Description

The current behavior of `Parse()` function will drop labels with zero int64 value and no unit. For example, a thread id with zero value is meaningful and no unit is applicable. This behavior will cause the thread id information getting dropped for specific samples since the key won't exists in the `NumLabel` map of decoded `Sample`.

Should this be fixed to support label with zero int64 value?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.