google / google/polymorphicDSL

Listeners should have visitErrorNode throw an exception by default

Open
#46 1 comment 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
Java
Stars
17
Forks
10
PR merge metrics
No merged PRs in 30d

Description

It is possible to get a false positive if errorNodes are encountered. The default implementation is to do nothing. The user can implement an exception to be thrown manually, but I'm concerned that it will be easy to forget and lead to difficult to diagnose bugs.

I'm going to see if this can be built into the generated code ANTLR produces with its "tool" code.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.