google / google/playground-elements

Naming conventions around "TypeScriptWorker"

Open
#215 0 comments 0 reactions 0 assignees View on GitHub
Needs Discussion
Dominant language
TypeScript
Stars
648
Forks
61
PR merge metrics
No merged PRs in 30d

Description

As discussed under the [PR for refactoring the Language Service](https://github.com/google/playground-elements/pull/211), we should move into calling the current "TypeScriptWorker" in a more general name as just a "WebWorker" or something similiar.

Some pointers from the PR to keep in mind:

- Rename the `typescript-worker` -directory to just `web-worker`
- Change the build output in RollUp to match (`playground-typescript-worker.js` => `playground-web-worker.js` )
- Change the worker file references in `playground-project.ts`
- Change the variable naming to remove typescript from it.

With these changes, we are creating a breaking change as the build output names change as informed by @aomarks [here](https://github.com/google/playground-elements/pull/211#issuecomment-927148690).

Creating a issue so that the needed steps can be documented before we decide to ship the changes

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.