google / google/perfetto

Improve performance of SQL strings in ExecuteQuery/ExecuteStatement functions

Open
#6,799 5 comments 0 reactions 1 assignee Claimed by @KaustAbhinand View on GitHub
enhancement fixit good first issue
Dominant language
C++
Stars
6.5k
Forks
868
Avg merge
2d 1h
Merged PRs (30d)
218

Description

There's a bunch of string copying and substrings happening which are largely unnecessary and can be removed. On the first hand, we should really trying to be using string views where possible. On the second hand, we should move this replacement *down* into the engine/SqlSource.

On the third hand, SqlSource itself should probably go away and be replaced by syntaqlite error tracking so that's there as well.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.