google / google/perfetto

Updating integration test screenshots doesn't trigger ui check

Open
#5,879 0 comments 0 reactions 0 assignees View on GitHub
ui
Dominant language
C++
Stars
6.5k
Forks
868
Avg merge
2d 1h
Merged PRs (30d)
218

Description

I've just uploaded #5877, which updates two screenshots for UI integration tests. I was surprised to see that the "Perfetto CI / ui (pull_request)" check was automatically skipped. That seems wrong given that the change updates the test expectations.

Contributor guide

Open the contributing guide

Research direction

Start by inspecting the configuration for the “Perfetto CI / ui (pull_request)” check and the UI integration test screenshot changes described in #5877. Trace its path or file filters and compare them with the changed screenshot paths; done means screenshot expectation changes trigger the UI check instead of being skipped.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp, github-actions
Domain
ci-cd, testing-qa
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
58/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.