google / google/perfetto

Slice debug track querying has poor performance

Open
#4,149 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
6.5k
Forks
868
Avg merge
2d 1h
Merged PRs (30d)
218

Description

Somewhere in the refactorings of dataset (especially when we did create vs createMaterialized) we lost the fact that, if depth is a computed column, it's quite expensive to create it (because it's computed using SQL window functions).

We should really materialize debug tables like this (at least if they're single tables but potentially even for pivoted tables?).

Contributor guide

Open the contributing guide

Research direction

Start by tracing the dataset refactor around create versus createMaterialized and the debug track query path; inspect how computed depth is produced with SQL window functions. Compare single-table and pivoted-table handling, then verify that debug tables avoid repeated depth computation while preserving query results.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp, sql
Domain
databases, performance
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.