google / google/perfetto

ui: Pressing escape or clicking outside a popup (on the timeline) should not cancel the selection

Open
#3,629 0 comments 0 reactions 1 assignee Claimed by @stevegolton View on GitHub
ui
Dominant language
C++
Stars
6.5k
Forks
868
Avg merge
2d 1h
Merged PRs (30d)
218

Description

Clicking outside a popup or pressing escape are both ways to close that popup, however they also have additional side effects as the event is propagated through the other elements that are clicked on / interact with hotkeys. The most grievous issue is this can cancel the selection on the timeline page.

More succinctly:
- Clicking outside a popup should have no other effect other than closing the popup.
- Pressing escape when a popup is open should have no other effect other than closing the popup.

See the attached video:

https://github.com/user-attachments/assets/82c6e3cf-a661-4634-9445-4b02df61a858

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.