google / google/peoplemath

Error swallowing in auth.interceptor.ts

Open
#136 0 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
TypeScript
Stars
129
Forks
39
Avg merge
1h 26m
Merged PRs (30d)
2

Description

https://github.com/google/peoplemath/blob/7e6d8a6695e1f9aa39cb25375a41056c8f627694/src/app/services/auth.interceptor.ts#L61

All non authentication errors are swallowed by the code above.

I think it needs to be changed to
```JavaScript
return throwError(err);
```
because
```JavaScript
of(err)
```
'eats' the error context, which bypass error checking in all layers above and catchError code, stops working.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.