google / google/osv.dev

Evaluate and enable cherrypick detection for cve-osv

Open
#2,577 5 comments 0 reactions 0 assignees View on GitHub
backlog data quality enhancement
Dominant language
Go
Stars
2.9k
Forks
369
Avg merge
1d 17h
Merged PRs (30d)
149

Description

Currently, for our cve-osv source, `detect_cherrypicks` is off. This means that when we enumerate affected git commits, we are only considering the branches that contain the referenced fix commits.

This occasionally lead to missed matches.

We should evaluate turning on cherrypick detection for cve-osv. This has some implications:
- This will slow down record processing time.
- Cherrypick detection is [not perfect](https://github.com/google/osv.dev/issues/24), which can lead to false positives if we don't correctly identify all cherrypicked fixes.

Related issues:
https://github.com/google/osv.dev/issues/2576#issuecomment-2336875125
https://github.com/google/osv.dev/issues/1910#issuecomment-1885825603

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.