google / google/osv-scanner

consider putting details about errors in `models.VulnerabilityResults`

Open
#675 4 comments 0 reactions 0 assignees View on GitHub
backlog V2 Wishlist
Dominant language
Go
Stars
11k
Forks
792
Avg merge
1d 20h
Merged PRs (30d)
48

Description

This was discussed in: https://github.com/google/osv-scanner/pull/501#discussion_r1401646226

Return error codes don't seem to be the right way to report what combination of vulnerability, called vulnerabilities, license violations. It's simpler to just return 0 or 1, and put the details about what kinds of issues are present in the json or `models.VulnerabilityResults` output.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.