google / google/osv-scalibr

Make sure Maven `settings.xml` are read correctly

Open
#409 4 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
643
Forks
198
Avg merge
2d 17h
Merged PRs (30d)
29

Description

Maven authentication information is stored in local `settings.xml`.

Considering the extractor uses virtual filesystem, we need to refactor `MavenRegistryAPIClient` to use the virtual filesystem to read the local settings.

`settings.xml` is [read](https://github.com/google/osv-scalibr/blob/main/clients/datasource/maven_registry.go#L81) when we construct `NewMavenRegistryAPIClient` and the client is constructed when the extractor is constructed which is before `Extract()` is called.

Contributor guide

Open the contributing guide

Research direction

Start in clients/datasource/maven_registry.go, especially NewMavenRegistryAPIClient and the settings.xml read at construction time. Trace how the extractor's virtual filesystem becomes available by Extract(); done means Maven authentication settings are read through that filesystem at the appropriate point, with relevant existing tests updated or added.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
tooling
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.